Add npm to ansible #955
Merged
Add npm to ansible #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
approved these changes
Mar 11, 2024
jugglinmike
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Looks good to me.
Thanks for including your research on that Asana task, @howard-e. This would have been a much more straightforward diagnosis if the script reported errors. I've filed an issue to improve error reporting along these lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this Asana task, where the import tests job was failing in staging and production. NPM was not installed on provisioning of the server, which is why the import tests job was failing.