-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to include automatic deployments to staging #912
Conversation
…once the development branch is updated
deploy/README.md
Outdated
@@ -69,6 +69,7 @@ To deploy this project to server: | |||
3. Obtain a copy of the `ansible-vault-password.txt` file in LastPass and place it in the directory which contains this document. | |||
4. Install [Ansible](https://www.ansible.com/) version 2.11. Instructions for macOS are as follows: | |||
- Install Ansible at the specific 2.11 version: `python3 -m pip install --user ansible-core==2.11.1` | |||
- Install `ansible.posix` to make use of the [ansible.posix.synchronize](https://docs.ansible.com/ansible/latest/collections/ansible/posix/synchronize_module.html#ansible-posix-synchronize-module-a-wrapper-around-rsync-to-make-common-tasks-in-your-playbooks-quick-and-easy) module: `ansible-galaxy collection install ansible.posix` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this! We should put this step after sourcing the shell's RC file (otherwise, the invocation of ansible-galaxy
won't resolve)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on my catch! Done in b515765
… .github/workflows/deploy-staging.yml Co-authored-by: jugglinmike <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new workflow makes sense to me. Thanks for doing this and including the updated README step and typo fix.
I am the second approving reviewer but leaving it open since @alflennik is also listed as a reviewer
This PR adds
workflows/deploy-staging
to trigger automatic deploys to staging once thedevelopment
branch is updated.