Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test plan report update modal #893

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Remove test plan report update modal #893

merged 1 commit into from
Jan 11, 2024

Conversation

Paul-Clue
Copy link
Collaborator

see issue #891

This pull request removes the UpdateTestPlanReportModal from the app.

howard-e
howard-e approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up!

alflennik
alflennik approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this, that was a lot of dead code that could definitely trip new contributors up and get them confused. Not too much to test here, but I did verify that the test queue page is still working as normal.

@alflennik alflennik merged commit cff64e9 into main Jan 11, 2024
2 checks passed
@alflennik alflennik deleted the remove-test-plan-updater branch January 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howard-e howard-e howard-e approved these changes

@alflennik alflennik alflennik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Paul-Clue @alflennik @howard-e