Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty version strings on Data Management and Test Queue pages #839

Merged
merged 3 commits into from
Nov 20, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add versionString to mutation
Paul-Clue committed Nov 9, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit d5aa808f85e92b4607c53c4fdfed43ddf01616a2
2 changes: 2 additions & 0 deletions client/components/DataManagement/DataManagementRow/index.jsx
Original file line number Diff line number Diff line change
@@ -627,6 +627,7 @@ const DataManagementRow = ({
return (
<PhaseCell role="list">
<VersionString role="listitem" iconColor="#818F98">
{/* section: */}
{otherLatestVersion.versionString}
</VersionString>
<span role="listitem" className="review-complete">
@@ -684,6 +685,7 @@ const DataManagementRow = ({
linkRef={draftVersionStringRef}
linkHref={`/test-review/${latestVersion.gitSha}/${latestVersion.testPlan.directory}`}
>
{/* section: */}
{latestVersion.versionString}
</VersionString>
{isAdmin &&
2 changes: 2 additions & 0 deletions client/components/DataManagement/queries.js
Original file line number Diff line number Diff line change
@@ -108,6 +108,7 @@ export const UPDATE_TEST_PLAN_VERSION_PHASE = gql`
phase
gitSha
gitMessage
versionString
updatedAt
draftPhaseReachedAt
candidatePhaseReachedAt
@@ -153,6 +154,7 @@ export const UPDATE_TEST_PLAN_VERSION_RECOMMENDED_TARGET_DATE = gql`
phase
gitSha
gitMessage
versionString
updatedAt
draftPhaseReachedAt
candidatePhaseReachedAt

Unchanged files with check annotations Beta

});
// TODO: Revise timeout with pageReady check
it.skip('renders Test Queue page instructions', async () => {

Check warning on line 52 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test

Check warning on line 52 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test
// allow page time to load
await waitFor(() => new Promise(res => setTimeout(res, 0)));
expect(element).toHaveTextContent('Loading');
});
it.skip('renders Test Queue page instructions', async () => {

Check warning on line 108 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test

Check warning on line 108 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test
// allow page time to load
await waitFor(() => new Promise(res => setTimeout(res, 0)));
expect(voiceOverElements.length).toEqual(0);
});
it.skip('renders add test plan modal on button click', async () => {

Check warning on line 208 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test

Check warning on line 208 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test
// allow page time to load
await waitFor(() => new Promise(res => setTimeout(res, 0)));
expect(element).toHaveTextContent('Loading');
});
it.skip('renders Test Queue page instructions', async () => {

Check warning on line 247 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test

Check warning on line 247 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test
// allow page time to load
await waitFor(() => new Promise(res => setTimeout(res, 0)));
expect(assignedTestsElements.length).toBeGreaterThanOrEqual(1);
});
it.skip('renders add test plan modal on button click', async () => {

Check warning on line 292 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test

Check warning on line 292 in client/tests/TestQueue.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test
// allow page time to load
await waitFor(() => new Promise(res => setTimeout(res, 0)));
return wrapper;
};
describe.skip('render', () => {

Check warning on line 22 in client/tests/TestRun.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test suite

Check warning on line 22 in client/tests/TestRun.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test suite
describe('loading when there are no tests', () => {
let wrapper;
beforeEach(() => {
return wrapper;
};
describe.skip('render', () => {

Check warning on line 16 in client/tests/UserSettings.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test suite

Check warning on line 16 in client/tests/UserSettings.test.jsx

GitHub Actions / Using NodeJS and Postgres 12

Disabled test suite
describe('user is not signed in', () => {
let wrapper;
beforeEach(() => {