Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Test Reports" text, nav breakpoint change from 'lg' to 'xl' #828

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

stalgiag
Copy link
Contributor

@stalgiag stalgiag commented Oct 26, 2023

Text changes

The text changes in this PR are as follows:
"Test Reports" -> "AT Interop Reports" in metadata titles
"Test Reports" -> "AT Interoperability Reports" in the nav link label.
"Test Reports" -> "Assistive Technology Interoperability Reports" in headings.

Note on nav styles

Previously with "Test Reports", while logged in a line break would happen in the nav items with viewports between 992px-1070px wide. At the lower end, the nav switches to a mobile view.

Now with "AT Interop Reports", the nav items have linebreaks with viewports between 992px-1114px.

Given that the linebreaks were an issue with "Test Reports" and that all possible copy changes here would've expanded the linebreak viewing space, I decided it best to change the nav breakpoint to the "xl" bootstrap breakpoint.

see #795

Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the fixes and confirmed that there are no more errant references to "test reports" remaining, and wow, the word report is used a LOT in the codebase. Thanks for noticing that the nav bar needed to be tweaked, it's looking great.

@stalgiag stalgiag merged commit 662303d into main Nov 8, 2023
2 checks passed
@stalgiag stalgiag deleted the change-test-reports-title branch November 8, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants