Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate At / Browser combinations in the Test Queue #813

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

Paul-Clue
Copy link
Collaborator

see #793

This Pull Request fixes the issue of admins being able to add invalid At and Browser combination test plan runs to the test queue.

While adding a test plan run to the test queue, the user was able to select the desired assistive technology and then still had the option of choosing any browser type along with it. This was a problem because not all Ats work with all browsers.

The fix makes it so that only valid assistive technologies and browser combinations could be selected in the UI.

Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, code looks clean, tests pass, and it works perfectly.

Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimally intrusive, works well, good job!

@Paul-Clue Paul-Clue merged commit 65a3e02 into main Oct 26, 2023
2 checks passed
@Paul-Clue Paul-Clue deleted the at-browsers-invalid-combos branch October 26, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants