Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Assertion priorities to use MUST/SHOULD instead of REQUIRED/OPTIONAL #770

Merged

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Sep 6, 2023

Resolves #737.

This branches off of #765.

@howard-e howard-e marked this pull request as ready for review September 6, 2023 16:04
@howard-e howard-e force-pushed the improve-results-summary-table branch from f469bc8 to f9a334f Compare September 6, 2023 23:31
@howard-e howard-e force-pushed the update-assertion-priorities-language branch 2 times, most recently from e43aa51 to ef4e6d9 Compare September 6, 2023 23:49
@howard-e howard-e force-pushed the improve-results-summary-table branch from 4a12d0f to 703ea3c Compare September 28, 2023 20:52
@howard-e howard-e force-pushed the update-assertion-priorities-language branch from ef4e6d9 to a97aeb2 Compare September 28, 2023 21:02
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good to approve. I verified that the terminology has changed in the app. But I have a caveat, that I think we need to revisit the outdated terminology currently still used in the codebase as part of the effort to support the V2 test format.

@alflennik alflennik merged commit 36bf143 into improve-results-summary-table Oct 5, 2023
@alflennik alflennik deleted the update-assertion-priorities-language branch October 5, 2023 17:19
alflennik added a commit that referenced this pull request Oct 5, 2023
* initial model, migration, and seeder

* seeders test plan ids

* test plan service

* fixing migration

* updating migrations to have foreign keys

* Implementing Howard's feedback

* Start to migrations and functions to support the DB change for further support of 648

* Add phase to TestPlanVersion

* Update query and resolvers for test plan version mutations

* Restored viewing of CandidateTestPlanRun

* Fix graphql.schema

* Rename TestPlanVersion date fields with 'status' in name to 'phase'

* Add approvedAt column to TestPlanReport

* Rename candidateStatusReachedAt to approvedAt

* Update migration to be more clear and help in functional priority of following migrations

* Start to new Test Plan Results Table

* Update styling

* Fix issue with submitting test results with new query shape; update
blockquote styling

* Add space between Run History and above TestPlanResults table on report results page

* Fix optional priority string not being shown in TestPlanResultsTable component

* Add missing border-bottom to test result heading on reports results page

* Changes after rebase

* Update Assertion priorities to use MUST/SHOULD instead of REQUIRED/OPTIONAL (#770)

* Start to migrations and functions to support the DB change for further support of 648

* Add phase to TestPlanVersion

* Update query and resolvers for test plan version mutations

* Restored viewing of CandidateTestPlanRun

* Rename TestPlanVersion date fields with 'status' in name to 'phase'

* Rename candidateStatusReachedAt to approvedAt

* Update migration to be more clear and help in functional priority of following migrations

* Update REQUIRED and OPTIONAL assertion priorities to be MUST and SHOULD respectively

* Add box back to reports

---------

Co-authored-by: Erika Miguel <[email protected]>
Co-authored-by: alflennik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise reports to show assertion priorities as MUST/SHOULD/MAY instead of REQUIRED/OPTIONAL
2 participants