-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Assertion priorities to use MUST/SHOULD instead of REQUIRED/OPTIONAL #770
Merged
alflennik
merged 8 commits into
improve-results-summary-table
from
update-assertion-priorities-language
Oct 5, 2023
Merged
Update Assertion priorities to use MUST/SHOULD instead of REQUIRED/OPTIONAL #770
alflennik
merged 8 commits into
improve-results-summary-table
from
update-assertion-priorities-language
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f469bc8
to
f9a334f
Compare
e43aa51
to
ef4e6d9
Compare
4a12d0f
to
703ea3c
Compare
…following migrations
ef4e6d9
to
a97aeb2
Compare
alflennik
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good to approve. I verified that the terminology has changed in the app. But I have a caveat, that I think we need to revisit the outdated terminology currently still used in the codebase as part of the effort to support the V2 test format.
alflennik
added a commit
that referenced
this pull request
Oct 5, 2023
* initial model, migration, and seeder * seeders test plan ids * test plan service * fixing migration * updating migrations to have foreign keys * Implementing Howard's feedback * Start to migrations and functions to support the DB change for further support of 648 * Add phase to TestPlanVersion * Update query and resolvers for test plan version mutations * Restored viewing of CandidateTestPlanRun * Fix graphql.schema * Rename TestPlanVersion date fields with 'status' in name to 'phase' * Add approvedAt column to TestPlanReport * Rename candidateStatusReachedAt to approvedAt * Update migration to be more clear and help in functional priority of following migrations * Start to new Test Plan Results Table * Update styling * Fix issue with submitting test results with new query shape; update blockquote styling * Add space between Run History and above TestPlanResults table on report results page * Fix optional priority string not being shown in TestPlanResultsTable component * Add missing border-bottom to test result heading on reports results page * Changes after rebase * Update Assertion priorities to use MUST/SHOULD instead of REQUIRED/OPTIONAL (#770) * Start to migrations and functions to support the DB change for further support of 648 * Add phase to TestPlanVersion * Update query and resolvers for test plan version mutations * Restored viewing of CandidateTestPlanRun * Rename TestPlanVersion date fields with 'status' in name to 'phase' * Rename candidateStatusReachedAt to approvedAt * Update migration to be more clear and help in functional priority of following migrations * Update REQUIRED and OPTIONAL assertion priorities to be MUST and SHOULD respectively * Add box back to reports --------- Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: alflennik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #737.
This branches off of #765.