Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing rows test management #622

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Conversation

evmiguel
Copy link
Contributor

@evmiguel evmiguel commented May 3, 2023

This PR addresses #580. To see, run yarn dev, and then navigate to the Management page. Notice that all the test plan are present, even though not all of them have been tested.


@@ -15,6 +15,15 @@ export const TEST_MANAGEMENT_PAGE_QUERY = gql`
id
name
}
testPlans {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEWERS: even if we do not go with a separate Test Plan table, this is the query I would like to use.

Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, code looks good and I verified that the issue identified by Matt is fixed.

@howard-e howard-e force-pushed the fix-missing-rows-test-management branch from d11437a to 568279f Compare June 1, 2023 17:27
@howard-e howard-e merged commit b848b10 into main Jun 7, 2023
@howard-e howard-e deleted the fix-missing-rows-test-management branch June 7, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Management Page: 19 test plans are missing from the status summary table
3 participants