Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Testers.txt File #304

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Add Testers.txt File #304

merged 2 commits into from
Jul 12, 2021

Conversation

alflennik
Copy link
Contributor

Note: the base is currently GraphQL Client but when that is merged I will change it to develop.

Adds a testers.txt file with a list of users who should be allowed into the app as testers. Admins do not need to be included.

@alflennik alflennik requested review from howard-e and jesdaigle June 17, 2021 18:03
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

@@ -76,7 +70,7 @@ module.exports = {
response.data.data.viewer.username
);
},
async getGithubTeams({ githubAccessToken, githubUsername }) {
async isMemberOfAdminTeam({ githubAccessToken, githubUsername }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner way 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants