Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sortable issues table, improved issues table heading #1266

Merged
merged 7 commits into from
Nov 5, 2024
Merged

feat: Sortable issues table, improved issues table heading #1266

merged 7 commits into from
Nov 5, 2024

Conversation

stalgiag
Copy link
Contributor

see #1251
see #1252

This PR makes the issues table sortable and filterable by issue status. It also updates the heading to reveal the count of open/closed issues.

@stalgiag stalgiag requested a review from howard-e October 30, 2024 18:06
howard-e
howard-e approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a small suggestion. Should be easy to resolve #1250 afterwards with this, with how well contained it is!

client/components/SortableIssuesTable/index.jsx Outdated Show resolved Hide resolved
@howard-e
Copy link
Contributor

howard-e commented Nov 5, 2024

@stalgiag looks like a recent w3c/aria-at test change got merged. Noticed the same on development so snapshots need an update. Feel free to merge afterwards

@stalgiag
Copy link
Contributor Author

stalgiag commented Nov 5, 2024

@stalgiag looks like a recent w3c/aria-at test change got merged. Noticed the same on development so snapshots need an update. Feel free to merge afterwards

Yep I am updating now. Thank you!

@stalgiag stalgiag merged commit 18fd21c into development Nov 5, 2024
2 checks passed
@stalgiag stalgiag deleted the sortable-issues-table branch November 5, 2024 17:07
This was referenced Nov 7, 2024
Merged
Merged
howard-e added a commit that referenced this pull request Nov 7, 2024
@howard-e
Merge pull request #1271 from w3c/development
098cda8 
Create November 7, 2024 Release

Includes the following changes:
* #1265, to address #1248
* #1266, to address #1251 and #1252
* #1269, to address #1250
* #1272
@howard-e howard-e mentioned this pull request Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howard-e howard-e howard-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stalgiag @howard-e