Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Assertion with EXCLUDE priority causing test result submit errors #1229

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Oct 3, 2024

Address #1228.

This seems to be a special case that happens when the assertion is excluded in tests the tests.csv and then included in *-commands.csv's assertionExceptions with a non-excluding priority. For example:

@howard-e howard-e changed the title fix: Assertion with EXCLUDE priority causing submit errors fix: Assertion with EXCLUDE priority causing test result submit errors Oct 3, 2024
# Conflicts:
#	client/tests/e2e/snapshots/saved/_data-management.html
#	server/scripts/populate-test-data/pg_dump_test_data.sql
Copy link
Contributor

@jugglinmike jugglinmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the development branch locally, confirmed the erroneous behavior, ran this patch locally, and verified the fix. Nice going, @howard-e!

@jugglinmike jugglinmike merged commit d7cc1fd into development Oct 9, 2024
2 checks passed
@jugglinmike jugglinmike deleted the patch-excluded-assertion-submit-error branch October 9, 2024 04:05
howard-e added a commit that referenced this pull request Oct 9, 2024
Create October 9, 2024 Release

Includes the following changes:
* #1214
* #1208, which addresses #1201
* #1225
* #1227, which addresses #1226
* #1224, which addresses #759
* #1229, which addresses #1228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants