Use UTC time for date strings #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Looks good! Happy this was found and at least this is just a display concern. It doesn't seem like it directly affected any database persisted data. I figured there could be an issue with how the app was searching created GH issues with the issuesResolver search but haven't observed any problems there.
Looking back at this and where the project currently is as well, think it may be best to eventually move these date utilities to the shared project and serve it from there. There is already a minor duplication happening here but it will make it easier to switch out if needed.
| @@ -25,70 +25,42 @@ async function cleanAndNormalizeSnapshot(page) { | |||
| stylesToRemove.forEach(el => el.remove()); | |||
| }); | |||
|
|
|||
| // Remove elements with Date or status content that might differ between local and CI | |||
| // TODO: Investigate why "Ready for Review" and "Review in Progress" status | |||
There was a problem hiding this comment.
Thanks for leaving this note
howard-e
added a commit
that referenced
this pull request
Aug 6, 2024
Addresses follow up comment in #1177 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting the
snapshot-testingbranch since there are related changes here but broke this out into a separate PR since that PR has already been reviewed and the changes here will have effects outside of snapshot testing.While writing snapshot tests, I noticed that dates were inconsistent between my system and CI. Based on @howard-e 's advice, I changed all of the calls to
momentto bemoment.utc. This fixes the problem.The only remaining unexpected issue uncovered by the snapshot tests is related to the rollback of the 'Ready to Review', 'Review in Progress', and 'Previously Viewed' statuses after e2e testing. This can be addressed separately.