-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update metrics calculations and related UI components #1172
fix: Update metrics calculations and related UI components #1172
Conversation
…impacting the frontend directly because the calls were being done again on the reports pages)
testPlanReport.testPlanRuns.find(testPlanRun => | ||
testPlanRun.testResults?.some(testResult => !!testResult.completedAt) | ||
) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: Found odd behaviors when doing the following:
- Assigning self to report row on Test Queue
- Assigning other tester to report row on Test Queue
- Opening the report as the other tester navigating and this resolver could silently throw errors when navigating so attempted to resolve that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and this resolves the issues as listed. The code looks good and the unit tests are welcome since it is difficult to get the DB into the various related testing states. Looks good to me!
See #1173 and #1174
This PR addresses several issues:
Math.round()
withMath.floor()
in presenting metrics'supportPercent
.