Use assertion phrase in test result table #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
April 8th 2024 Production Release
evmiguel
requested changes
May 1, 2024
There was a problem hiding this comment.
@Paul-Clue great work! It works well for me, but I do notice that the assertion phrase is not capitalized. Could you make sure that it is capitalized?
| @@ -198,6 +203,8 @@ export const TEST_RUN_PAGE_ANON_QUERY = gql` | |||
| assertion { | |||
| id | |||
| text | |||
| phrase | |||
There was a problem hiding this comment.
Will the query work if you delete the duplicate phrase?
There was a problem hiding this comment.
Got it. Good catch!
| @@ -766,6 +784,8 @@ export const SAVE_TEST_RESULT_MUTATION = gql` | |||
| assertion { | |||
| id | |||
| text | |||
| phrase | |||
There was a problem hiding this comment.
Same comment about the duplicate phrase.
There was a problem hiding this comment.
Got this one too!
evmiguel
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #744
This pull request adds the assertion phrase instead of the assertion statement to the test results table.