Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign Tester Menu options are incorrectly sorted #993

Open
howard-e opened this issue Mar 28, 2024 · 0 comments
Open

Assign Tester Menu options are incorrectly sorted #993

howard-e opened this issue Mar 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@howard-e
Copy link
Contributor

The Assign Tester Menu options for an admin are being incorrectly sorted. The values are being sorted alphabetically but not in a case-insensitive way. The following screenshot shows a small subset of the tester options as being:

  • AlyssaGourley, IsaDC, Paul-Clue, SamuelHShaw, a11ydoer, alflennik ... and so on

The first 4 are taking precedence because they are capitalized. The expected order should be:

  • a11ydoer, alflennik, AlyssaGourley, IsaDC, Paul-Clue, SamuelHShaw ... and so on
screenshot showing small subset of tester options
@howard-e howard-e added the bug Something isn't working label Mar 28, 2024
@Paul-Clue Paul-Clue mentioned this issue May 1, 2024
Merged
alflennik added a commit that referenced this issue May 6, 2024
@Paul-Clue @howard-e @alflennik
fix: Correct sorting for the tester assignment menu, addresses #993 (#…
01c818f 
…1067)

* Fix tester menu sorting

* Use localeCompare

* Sort initial tester assign dropdown

* Remove debugging code

---------

Co-authored-by: Howard Edwards <[email protected]>
Co-authored-by: alflennik <[email protected]>
@ccanash ccanash moved this from Todo to In staging/sandbox in Ops and maintenance support for ARIA-AT and APG May 8, 2024
@howard-e howard-e mentioned this issue May 28, 2024
Merged
howard-e added a commit that referenced this issue May 28, 2024
@howard-e @alflennik
@Paul-Clue @gnarf @evmiguel @jugglinmike
Merge pull request #1112 from w3c/development
9f5ada4 
Issues addressed:
* #1105, addresses w3c/aria-at#1070
* #1053, addresses w3c/aria-practices#2971
* #1097, addresses #977
* #1095, addresses #991
* #1093, addresses #934
* #1000, addresses #818
* #1089, addresses #992
* #1067, addresses #993
* #1056, addresses w3c/wai-aria-practices#212

---------

Co-authored-by: alflennik <[email protected]>
Co-authored-by: Paul Clue <[email protected]>
Co-authored-by: Mx Corey Frang <[email protected]>
Co-authored-by: Mx. Corey Frang <[email protected]>
Co-authored-by: Erika Miguel <[email protected]>
Co-authored-by: Mike Pennisi <[email protected]>
@ccanash ccanash moved this from In staging/sandbox to In production / Completed in Ops and maintenance support for ARIA-AT and APG Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Ops and maintenance support for ARIA-AT and APG
Status: In production / Completed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@howard-e