Skip to content

Commit

Permalink
Add collapsible areas for Test Plan Versions History page (#794)
Browse files Browse the repository at this point in the history
* Fix bug that would allow testPlanVersion to be updated to RECOMMENDED before the associated reports were all marked as final (but the tests were 100% done in the Test Queue)

* Refine raise an issue behavior (#753)

* Refine raise an issue behavior

* Address feedback

* Fixed squished dot icon

* Address last feedback

* Hide closed issues on datamgmt page

* Fix for test results not being automatically saved when navigating through Test Run

* Filter and sort functionality for Data Management table (#750)

* First pass on functioning sort buttons for DataManagePage

* Functioning sort

* Filter functionality for DataManagement

* Refactor filter buttons on DataManagement to reduce complexity

* Filter buttons as separate component

* DataManagement page, break sort out into dedicated hook

* DataManagement page, dedicated hook for filtering

* DataManagement, add constant for test plan version phases to simplify hooks code

* Add relevant dynamic aria attributes to DataManagement column sort elements

* Add relevant dynamic aria attributes to DataManagement filter buttons

* unit tests for SortableTableHeader

* unit tests for FilterButtons

* unit tests for useDataManagementTableSorting hook

* Add unit tests for useDataManagementTableFiltering hook

* Filter buttons only show buttons that have have label, handle testPlans with multiple versions, ...

useDataManagementTableFiltering don't generate label for buttons that have no associated plans

* Break out overall phase derivation logic into dedicated hooks, functional filter and sort

* Simplify useDerivedTestPlanOverallPhase

* Additional unit tests for additional hooks and to test scenarios with multiple test plan versions for a single test plan

hook rename

* Different UX click interaction sequence with SortableTableHeader

* Correct interpretation of alphabetical ascending/descending

* Rename DataManagement/hooks.js to filterSortHooks

* Move sorting and filtering enums to more specific locations based on use

* Fix file locations in unit tests, DataManagement, FilterButtons, SortableTableHeader

* Smaller margin between buttons, FilterButtons

* First pass on functioning sort buttons for DataManagePage

* Functioning sort

* Filter functionality for DataManagement

* Refactor filter buttons on DataManagement to reduce complexity

* Filter buttons as separate component

* DataManagement page, break sort out into dedicated hook

* DataManagement page, dedicated hook for filtering

* DataManagement, add constant for test plan version phases to simplify hooks code

* Add relevant dynamic aria attributes to DataManagement column sort elements

* Add relevant dynamic aria attributes to DataManagement filter buttons

* unit tests for SortableTableHeader

* unit tests for FilterButtons

* unit tests for useDataManagementTableSorting hook

* Add unit tests for useDataManagementTableFiltering hook

* Filter buttons only show buttons that have have label, handle testPlans with multiple versions, ...

useDataManagementTableFiltering don't generate label for buttons that have no associated plans

* Break out overall phase derivation logic into dedicated hooks, functional filter and sort

* Simplify useDerivedTestPlanOverallPhase

* Additional unit tests for additional hooks and to test scenarios with multiple test plan versions for a single test plan

hook rename

* Different UX click interaction sequence with SortableTableHeader

* Correct interpretation of alphabetical ascending/descending

* Rename DataManagement/hooks.js to filterSortHooks

* Move sorting and filtering enums to more specific locations based on use

* Fix file locations in unit tests, DataManagement, FilterButtons, SortableTableHeader

* Smaller margin between buttons, FilterButtons

* Cleanup after rebase

* Render SortableTableHeader inside <table> for test to dismiss warning

* Add AriaLiveRegionProvider, Update DataManagement table to use it

* Allow SortableTableHeader component to work without AriaLiveRegionProvider

* Explicitly support 'DEPRECATED' phase for `TestPlanVersion.phase` (#749)

* Start to support for sunset phase

* Explicitly use 'DEPRECATED' phase for TestPlanVersion.phase

* Add checks to prevent test plan versions in R&D or Deprecated from being shown in data management dropdown

* Remove duplicate updateTestPlanVersion call

* Reuse phase variable

* Add copy for deprecated reports with DisclaimerInfo component

* Exclude 'DEPRECATED' testPlanVersions on DataManagement page query

* Ensure only reports marked as final are displayed on /embed/reports/<pattern>

* Fix test

* Update failing test

* Adjust semantic structure on Data Management Page (#752)

* Adjust cell items for data management row to use list-related roles; update aria-labels

* Address PR feedback

* Remove width:max-content

* Address PR feedback

* Formatting

* Address feedback

* Adjust BasicModal to support AtAndBrowserDetailsModal closing

* Stop assign menu dropdown from creating unintended bottom space with the parent container

* Formatting

* Close #755

* Close #754

* Remove superfluous header from TestPlanReportStatusDialog (#766)

* Revise required reports conditions (#764)

* Revise required reports approach

* Update tests

* Revert dev.env

* Update Version History Page (#767)

* Apply correct sort order for Timeline for All Versions section

* Update headings used on Versions page

* Add aria-labelledby's for tables

* Add &nbsp; for applicable spaces so the text is properly announced by NVDA

* Add migration to add missing deprecatedAt dates and to also properly set the candidatePhaseReachedAt dates to more practical dates after the migrations (if candidatePhaseReachedAt < draftPhaseReachedAt, set it candidatePhaseReachedAt to draftPhaseReachedAt + 1day)

* Test Plan Versions Page: Use standard testPlanVersions descending sort and show all phases being included in Version Summary

* Switch issues search support for checking against hidden body content instead

* Fix TestPlanReportStatusDialog using d (day of the week) and y (era)

* Explicit check for older date when deprecating existing RD test plan versions during import

* Update hidden message content in github issue

* Update query for anon user on TestRun page

* Keep overall status pill from drifting to center of cell

* Fix R&D only TestPlanVersion's table not being shown

* Use aria-label for heading to prevent space being announced

* Update date format used in aria-label

* Make version history a drop down

* comment out unused variable

* Fix responsiveness

* Remove comments and logs

* Changes after merge

* Fix icon color

* Fix padding for timeline heading

* Fix console errors and delete comments

* Fix conflicts that caused error

* Implement required changes from review

---------

Co-authored-by: Howard Edwards <[email protected]>
Co-authored-by: Alexander Flenniken <[email protected]>
Co-authored-by: Stalgia Grigg <[email protected]>
  • Loading branch information
4 people authored Oct 18, 2023
1 parent f931d34 commit c1b329c
Show file tree
Hide file tree
Showing 4 changed files with 318 additions and 165 deletions.
12 changes: 3 additions & 9 deletions client/components/DataManagement/DataManagementRow/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -754,21 +754,15 @@ const DataManagementRow = ({
// If a version of the plan is not in the candidate phase and there is a recommended
// version, show string "Review of VERSION_STRING completed DATE"
if (otherTestPlanVersions.length) {
const {
latestVersion: otherLatestVersion,
latestVersionDate: otherLatestVersionDate
} = getVersionData(otherTestPlanVersions);
const { latestVersion: otherLatestVersion } =
getVersionData(otherTestPlanVersions);

const completionDate =
otherLatestVersion.recommendedPhaseReachedAt;

return (
<PhaseCell role="list">
<VersionString
role="listitem"
date={otherLatestVersionDate}
iconColor="#818F98"
>
<VersionString role="listitem" iconColor="#818F98">
{otherLatestVersion.versionString}
</VersionString>
<span role="listitem" className="review-complete">
Expand Down
Loading

0 comments on commit c1b329c

Please sign in to comment.