Break out in-line filter into function sufficiently support readabili…

…ty purposes
w3c · Feb 6, 2024 · bba8ad4 · bba8ad4
1 parent 942223d
commit bba8ad4
Showing 1 changed file with 29 additions and 11 deletions.
diff --git a/server/resolvers/TestPlanRunOperations/createTestResultSkeleton.js b/server/resolvers/TestPlanRunOperations/createTestResultSkeleton.js
@@ -4,6 +4,25 @@ const {
     createAssertionResultId
 } = require('../../services/PopulatedData/locationOfDataId');
 
+/**
+ * Determine whether a given assertion belongs to a given scenario and includes
+ * at least one exception with a given priority.
+ *
+ * @param {Assertion} assertion
+ * @param {Scenario} scenario
+ * @param {string} priority
+ */
+const hasExceptionWithPriority = (assertion, scenario, priority) => {
+    return assertion.assertionExceptions?.some(
+        exception =>
+            scenario.commands.find(
+                command =>
+                    command.id === exception.commandId &&
+                    command.atOperatingMode === exception.settings
+            ) && exception.priority === priority
+    );
+};
+
 const createTestResultSkeleton = ({
     test,
     testPlanRun,
@@ -31,17 +50,16 @@ const createTestResultSkeleton = ({
                     scenarioId: scenario.id,
                     output: null,
                     assertionResults: test.assertions
-                        // Filter out assertionResults which were marked with a 0-priority exception
-                        .filter(assertion => {
-                            return !assertion.assertionExceptions?.some(
-                                e =>
-                                    scenario.commands.find(
-                                        c =>
-                                            c.id === e.commandId &&
-                                            c.atOperatingMode === e.settings
-                                    ) && e.priority === 'EXCLUDE'
-                            );
-                        })
+                        // Filter out assertionResults for the current scenario which were marked
+                        // with a 0-priority exception
+                        .filter(
+                            assertion =>
+                                !hasExceptionWithPriority(
+                                    assertion,
+                                    scenario,
+                                    'EXCLUDE'
+                                )
+                        )
                         .map(assertion => ({
                             id: createAssertionResultId(
                                 scenarioResultId,