Skip to content

Commit

Permalink
Update comments with reasoning for filtering out assertions that can …
Browse files Browse the repository at this point in the history
…possibly have no ids
  • Loading branch information
howard-e committed Feb 6, 2024
1 parent 45d3ed6 commit af9a5b0
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions client/components/TestRun/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -660,8 +660,12 @@ const TestRun = () => {
output: output,
unexpectedBehaviors: unexpectedBehaviors,
assertionResults: assertionResults
// All assertions are always being passed from the TestRenderer results, but in the instance where
// there is a 0-priority exception, and id won't be provided and that cannot be saved
// All assertions are always being passed from the TestRenderer results, but
// when there is a 0-priority assertion exception, an id won't be provided,
// so do not include that result.
// This is due to the TestRenderer still requiring the position of the
// excluded assertion, but it can be removed at this point before being passed
// to the server
.filter(el => !!el.id)
.map(({ id, passed }) => ({
id,
Expand Down

0 comments on commit af9a5b0

Please sign in to comment.