Skip to content

Commit

Permalink
fix: Allow AT and Browser versions to be edited when bot run is assig…
Browse files Browse the repository at this point in the history 
…ned to manual tester for evaluation (#1279)

* Allow AT and Browser versions to be edited when bot assignment is assigned to manual tester to be evaluated

* Update snapshots

* Update snapshots
  • Loading branch information
@howard-e
howard-e authored Dec 5, 2024
1 parent 53f6ced commit a6c0bda
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 34 deletions.
4 changes: 2 additions & 2 deletions client/components/TestRun/index.jsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ const TestRun = () => {
setCurrentBrowserVersion(currentBrowserVersion);
// Testers do not need to change AT/Browser versions
// while assigning verdicts for previously automated tests
if (testPlanRun?.initiatedByAutomation) {
if (!isSignedIn || tester?.isBot) {
setIsShowingAtBrowserModal(false);
}
setPageReady(true);
Expand Down Expand Up @@ -1149,7 +1149,7 @@ const TestRun = () => {
browser={`${testPlanReport.browser?.name}${
isViewingRun ? ` ${currentBrowserVersion?.name || ''}` : ''
}`}
showEditAtBrowser={isViewingRun && !testPlanRun.initiatedByAutomation}
showEditAtBrowser={isSignedIn && isViewingRun && !openAsUser?.isBot}
openAsUser={openAsUser}
testResults={testResults}
testCount={testCount}
Expand Down
42 changes: 21 additions & 21 deletions client/tests/e2e/snapshots/saved/_data-management.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,10 @@ <h3>
<label class="disclosure-form-label form-label"
>Test Plan</label
><select class="form-select">
<option value="86">
<option value="88">
Action Menu Button Example Using aria-activedescendant
</option>
<option value="85">
<option value="87">
Action Menu Button Example Using element.focus()
</option>
<option value="81">Alert Example</option>
Expand Down Expand Up @@ -247,37 +247,37 @@ <h3>
<option value="78">
Link Example 1 (span element with text content)
</option>
<option value="71">
<option value="86">
Link Example 2 (img element with alt attribute)
</option>
<option value="70">
<option value="85">
Link Example 3 (CSS :before content property on a span
element)
</option>
<option value="49">Main Landmark</option>
<option value="60">Media Seek Slider</option>
<option value="54">Meter</option>
<option value="88">Modal Dialog Example</option>
<option value="87">Navigation Menu Button</option>
<option value="90">Modal Dialog Example</option>
<option value="89">Navigation Menu Button</option>
<option value="74">
Radio Group Example Using Roving tabindex
</option>
<option value="89">
<option value="91">
Radio Group Example Using aria-activedescendant
</option>
<option value="59">Rating Slider</option>
<option value="39">Select Only Combobox Example</option>
<option value="61">Switch Example</option>
<option value="62">Tabs with Manual Activation</option>
<option value="90">Toggle Button</option>
<option value="92">Toggle Button</option>
<option value="64">Vertical Temperature Slider</option>
</select>
</div>
<div class="form-group">
<label class="disclosure-form-label form-label"
>Test Plan Version</label
><select aria-disabled="false" class="form-select">
<option value="86">
<option value="88">
Sep 18, 2024 at 6:30:36 pm UTC Add quick nav instruction
for test 9 with VoiceOver (#1127) (122e07a)
</option>
Expand Down Expand Up @@ -567,7 +567,7 @@ <h2>Test Plans Status Summary</h2>
<span
class="full-width auto-width css-36z7cz"
role="listitem"
><a href="/test-review/86"
><a href="/test-review/88"
><span
><svg
aria-hidden="true"
Expand Down Expand Up @@ -743,7 +743,7 @@ <h2>Test Plans Status Summary</h2>
<span
class="full-width auto-width css-36z7cz"
role="listitem"
><a href="/test-review/88"
><a href="/test-review/90"
><span
><svg
aria-hidden="true"
Expand Down Expand Up @@ -1183,7 +1183,7 @@ <h2>Test Plans Status Summary</h2>
<span
class="full-width auto-width css-36z7cz"
role="listitem"
><a href="/test-review/90"
><a href="/test-review/92"
><span
><svg
aria-hidden="true"
Expand Down Expand Up @@ -1270,7 +1270,7 @@ <h2>Test Plans Status Summary</h2>
<span
class="full-width auto-width css-36z7cz"
role="listitem"
><a href="/test-review/85"
><a href="/test-review/87"
><span
><svg
aria-hidden="true"
Expand Down Expand Up @@ -2044,15 +2044,15 @@ <h2>Test Plans Status Summary</h2>
<td>
<div class="css-bpz90">
<span class="rd full-width css-be9e2a">R&amp;D</span>
<p class="review-text">Complete <b>Aug 23, 2023</b></p>
<p class="review-text">Complete <b>Nov 20, 2024</b></p>
</div>
</td>
<td>
<div role="list" aria-setsize="2" class="css-1bj5ml9">
<span
class="full-width auto-width css-36z7cz"
role="listitem"
><a href="/test-review/71"
><a href="/test-review/86"
><span
><svg
aria-hidden="true"
Expand All @@ -2067,7 +2067,7 @@ <h2>Test Plans Status Summary</h2>
<path
fill="currentColor"
d="M256 512A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM369 209L241 337c-9.4 9.4-24.6 9.4-33.9 0l-64-64c-9.4-9.4-9.4-24.6 0-33.9s24.6-9.4 33.9 0l47 47L335 175c9.4-9.4 24.6-9.4 33.9 0s9.4 24.6 0 33.9z"></path></svg
><b>V23.08.23</b></span
><b>V24.11.20</b></span
></a
></span
><button
Expand Down Expand Up @@ -2099,15 +2099,15 @@ <h2>Test Plans Status Summary</h2>
<td>
<div class="css-bpz90">
<span class="rd full-width css-be9e2a">R&amp;D</span>
<p class="review-text">Complete <b>Aug 23, 2023</b></p>
<p class="review-text">Complete <b>Nov 20, 2024</b></p>
</div>
</td>
<td>
<div role="list" aria-setsize="2" class="css-1bj5ml9">
<span
class="full-width auto-width css-36z7cz"
role="listitem"
><a href="/test-review/70"
><a href="/test-review/85"
><span
><svg
aria-hidden="true"
Expand All @@ -2122,7 +2122,7 @@ <h2>Test Plans Status Summary</h2>
<path
fill="currentColor"
d="M256 512A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM369 209L241 337c-9.4 9.4-24.6 9.4-33.9 0l-64-64c-9.4-9.4-9.4-24.6 0-33.9s24.6-9.4 33.9 0l47 47L335 175c9.4-9.4 24.6-9.4 33.9 0s9.4 24.6 0 33.9z"></path></svg
><b>V23.08.23</b></span
><b>V24.11.20</b></span
></a
></span
><button
Expand Down Expand Up @@ -2311,7 +2311,7 @@ <h2>Test Plans Status Summary</h2>
<span
class="full-width auto-width css-36z7cz"
role="listitem"
><a href="/test-review/87"
><a href="/test-review/89"
><span
><svg
aria-hidden="true"
Expand Down Expand Up @@ -2415,7 +2415,7 @@ <h2>Test Plans Status Summary</h2>
<span
class="full-width auto-width css-36z7cz"
role="listitem"
><a href="/test-review/89"
><a href="/test-review/91"
><span
><svg
aria-hidden="true"
Expand Down
14 changes: 7 additions & 7 deletions client/tests/e2e/snapshots/saved/_reports.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,14 @@ <h2>Support Levels</h2>
<td>
<a
aria-label="Action Menu Button Example Using aria-activedescendant, RECOMMENDED report"
href="/report/86"
href="/report/88"
>Action Menu Button Example Using aria-activedescendant</a
><span class="recommended css-267jl0" aria-hidden="true"
>Recommended</span
>
</td>
<td>
<a aria-label="100%" href="/report/86/targets/21"
<a aria-label="100%" href="/report/88/targets/21"
><div class="progress clipped">
<div
class="front"
Expand All @@ -125,7 +125,7 @@ <h2>Support Levels</h2>
>
</td>
<td>
<a aria-label="100%" href="/report/86/targets/22"
<a aria-label="100%" href="/report/88/targets/22"
><div class="progress clipped">
<div
class="front"
Expand All @@ -137,7 +137,7 @@ <h2>Support Levels</h2>
>
</td>
<td>
<a aria-label="100%" href="/report/86/targets/23"
<a aria-label="100%" href="/report/88/targets/23"
><div class="progress clipped">
<div
class="front"
Expand All @@ -149,7 +149,7 @@ <h2>Support Levels</h2>
>
</td>
<td>
<a aria-label="100%" href="/report/86/targets/24"
<a aria-label="100%" href="/report/88/targets/24"
><div class="progress clipped">
<div
class="front"
Expand All @@ -161,7 +161,7 @@ <h2>Support Levels</h2>
>
</td>
<td>
<a aria-label="100%" href="/report/86/targets/25"
<a aria-label="100%" href="/report/88/targets/25"
><div class="progress clipped">
<div
class="front"
Expand All @@ -173,7 +173,7 @@ <h2>Support Levels</h2>
>
</td>
<td>
<a aria-label="100%" href="/report/86/targets/26"
<a aria-label="100%" href="/report/88/targets/26"
><div class="progress clipped">
<div
class="front"
Expand Down
8 changes: 4 additions & 4 deletions client/tests/e2e/snapshots/saved/_test-queue.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -205,14 +205,14 @@ <h3>
<label class="disclosure-form-label form-label"
>Test Plan</label
><select class="form-select">
<option value="86">
<option value="88">
Action Menu Button Example Using aria-activedescendant
</option>
<option value="1">Alert Example</option>
<option value="67">Checkbox Example (Mixed-State)</option>
<option value="84">Color Viewer Slider</option>
<option value="68">Command Button Example</option>
<option value="88">Modal Dialog Example</option>
<option value="90">Modal Dialog Example</option>
<option value="7">Select Only Combobox Example</option>
<option value="31">Toggle Button</option>
</select>
Expand All @@ -221,7 +221,7 @@ <h3>
<label class="disclosure-form-label form-label"
>Test Plan Version</label
><select aria-disabled="false" class="form-select">
<option value="86">
<option value="88">
Sep 18, 2024 at 6:30:36 pm UTC Add quick nav instruction
for test 9 with VoiceOver (#1127) (122e07a)
</option>
Expand Down Expand Up @@ -777,7 +777,7 @@ <h3>
aria-labelledby="disclosure-btn-modal-dialog-0"
class="css-19fsyrg">
<div class="css-25wfk">
<a href="/test-review/88"
<a href="/test-review/90"
><svg
aria-hidden="true"
focusable="false"
Expand Down

0 comments on commit a6c0bda

Please sign in to comment.