fix: Ignore renderableContent.info.references changes when doing te…

…st results copy (#1261)
w3c · Oct 24, 2024 · 41c968b · 41c968b
1 parent 56d144f
commit 41c968b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/client/tests/e2e/snapshots/saved/_data-management.html b/client/tests/e2e/snapshots/saved/_data-management.html
@@ -1193,7 +1193,7 @@ <h2>Test Plans Status Summary</h2>
                             <path
                               fill="currentColor"
                               d="M256 512A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM369 209L241 337c-9.4 9.4-24.6 9.4-33.9 0l-64-64c-9.4-9.4-9.4-24.6 0-33.9s24.6-9.4 33.9 0l47 47L335 175c9.4-9.4 24.6-9.4 33.9 0s9.4 24.6 0 33.9z"></path></svg
-                          ><b>V24.03.12</b></span
+                          ><b>V24.10.22</b></span
                         ></a
                       ></span
                     ><button
@@ -2402,7 +2402,7 @@ <h2>Test Plans Status Summary</h2>
                 <td>
                   <div class="css-bpz90">
                     <span class="rd full-width css-be9e2a">R&amp;D</span>
-                    <p class="review-text">Complete <b>Mar 13, 2024</b></p>
+                    <p class="review-text">Complete <b>Oct 22, 2024</b></p>
                   </div>
                 </td>
                 <td>
@@ -2425,7 +2425,7 @@ <h2>Test Plans Status Summary</h2>
                             <path
                               fill="currentColor"
                               d="M256 512A256 256 0 1 0 256 0a256 256 0 1 0 0 512zM369 209L241 337c-9.4 9.4-24.6 9.4-33.9 0l-64-64c-9.4-9.4-9.4-24.6 0-33.9s24.6-9.4 33.9 0l47 47L335 175c9.4-9.4 24.6-9.4 33.9 0s9.4 24.6 0 33.9z"></path></svg
-                          ><b>V24.03.13</b></span
+                          ><b>V24.10.22</b></span
                         ></a
                       ></span
                     ><button

diff --git a/server/util/aria.js b/server/util/aria.js
@@ -22,12 +22,14 @@ const testWithModifiedAttributes = (test, { forUpdateCompare }) => {
   // the assertionStatement, assertionPhrase, settings or instructions content
   // being changed
   if (forUpdateCompare) {
-    // Don't factor in settings and instructions changes during update
-    // eligibility in the case where ONLY the instructions has changed,
-    // so that the updated instructions or settings are shown when the
-    // copy process happens
+    // Don't factor in settings, instructions and references changes for
+    // update eligibility in the case where ONLY the settings, instructions or
+    // references has changed.
+    // The updated settings, instructions or references should be shown when
+    // the copy process is done
     propertiesToOmit.push('renderableContent.target.at.settings');
     propertiesToOmit.push('renderableContent.instructions');
+    propertiesToOmit.push('renderableContent.info.references');
     // for v1 format since structure is:
     // { ..., renderableContent: { 1: ..., 2: ... }, ... }
     for (let key in test.renderableContent) {