Enable nvda / firefox browser combination for automated testing

w3c · Mar 7, 2024 · 2791508 · 2791508
1 parent fff213d
commit 2791508
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/client/utils/automation.js b/client/utils/automation.js
@@ -2,7 +2,10 @@ export const isSupportedByResponseCollector = ctx => {
     if (!ctx || !ctx.at || !ctx.browser) {
         return false;
     }
-    return ctx.at.name === 'NVDA' && ctx.browser.name === 'Chrome';
+    return (
+        ctx.at.name === 'NVDA' &&
+        (ctx.browser.name === 'Chrome' || ctx.browser.name === 'Firefox')
+    );
 };
 
 export const isBot = user => user?.username?.toLowerCase().slice(-3) === 'bot';

diff --git a/server/services/GithubWorkflowService.js b/server/services/GithubWorkflowService.js
@@ -21,7 +21,7 @@ const ALGORITHM = 'RS256';
 // > the workflow file is on the default branch.
 //
 // https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch
-const WORKFLOW_FILE_NAME = 'nvda-chrome.yml';
+const WORKFLOW_FILE_NAME = 'nvda-test.yml';
 const WORKFLOW_REPO = 'bocoup/aria-at-gh-actions-helper';
 
 // Generated from the GitHub.com UI
@@ -126,13 +126,15 @@ const createGithubWorkflow = async ({ job, directory, gitSha }) => {
         jsonWebToken,
         GITHUB_APP_INSTALLATION_ID
     );
+    const browser = job.testPlanRun.testPlanReport.browser.name.toLowerCase();
     const inputs = {
         callback_url: `https://${callbackUrlHostname}/api/jobs/${job.id}/result`,
         status_url: `https://${callbackUrlHostname}/api/jobs/${job.id}/update`,
         callback_header: `x-automation-secret:${process.env.AUTOMATION_SCHEDULER_SECRET}`,
         work_dir: `tests/${directory}`,
         test_pattern: '{reference/**,test-*-nvda.*}',
-        aria_at_ref: gitSha
+        aria_at_ref: gitSha,
+        browser
     };
     const axiosConfig = {
         method: 'POST',