Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass controller from fetch, and abort SW fetch when it's canceled #1620

Merged
merged 4 commits into from
Jan 17, 2022

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Nov 19, 2021

This makes termination of SW fetch more explicit.
See #1612 and whatwg/fetch#1329


Preview | Diff

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this works. It seems that per #1544 there is some AbortSignal work that never finished here, but that shouldn't block your work.

docs/index.bs Outdated Show resolved Hide resolved
@noamr
Copy link
Contributor Author

noamr commented Dec 14, 2021

Ping @jakearchibald

Copy link
Contributor

@jakearchibald jakearchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry about the delay here.

@jakearchibald jakearchibald merged commit 9c7a50f into w3c:main Jan 17, 2022
annevk pushed a commit to whatwg/fetch that referenced this pull request Mar 14, 2022
This allows callers to perform certain actions on an ongoing fetch. Initially to abort or terminate it, and later on to conclude it.

This will eventually remove the need of using response as the object that retains timing info, as that creates certain ambiguities.

Corresponding Service Worker PR: w3c/ServiceWorker#1620.

Follow-up: #1403 and #1412.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants