Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a "service worker timing info" struct #1581

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Expose a "service worker timing info" struct #1581

merged 1 commit into from
Apr 27, 2021

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Apr 15, 2021 •
edited by pr-preview bot
Loading

to report worker-specific timing information to Navigation Timing.

In preparation for #1575

Preview | Diff

@noamr
Expose a "service worker timing info" struct
2f50de4 
to report worker-specific timing information to Navigation Timing.

In preparation for w3c#1575
jakearchibald
jakearchibald approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@jakearchibald jakearchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jakearchibald
jakearchibald requested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@jakearchibald jakearchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, waiting on IPR. Give me a shout when that happens.

@noamr
Copy link
Contributor Author

noamr commented Apr 23, 2021

But, waiting on IPR. Give me a shout when that happens.

Thanks! I applied for Invited Expert a week ago, how do I find out where it stands?

@ylafon
Copy link
Member

ylafon commented Apr 23, 2021

Hi @noamr I sent you a one-off IPR declaration, if you plan to do more contribution then sure, being an IE will be more efficient.

@noamr
Copy link
Contributor Author

noamr commented Apr 23, 2021 •
edited
Loading

Hi @noamr I sent you a one-off IPR declaration, if you plan to do more contribution then sure, being an IE will be more efficient.

I have this and an additional PR pending (#1575). Not sure how much I plan to contribute in the future. Would a one-off PR declaration suffice for 2 PRs?

@ylafon
Copy link
Member

ylafon commented Apr 23, 2021

@jakearchibald IPR cleared.
And it seems that IPR status is good also for #1575 (if not, ping me there)

@noamr
Copy link
Contributor Author

noamr commented Apr 27, 2021

@jakearchibald ping for merge?

@jakearchibald jakearchibald merged commit b807be1 into w3c:main Apr 27, 2021
@jakearchibald
Copy link
Contributor

Thanks for the ping. I'd missed this.

@noamr noamr deleted the timing-info-struct branch April 27, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakearchibald jakearchibald jakearchibald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noamr @ylafon @jakearchibald