Do not change default return type for getImageData #105
Conversation
|
This change would leave the proposal without a way to get the image data for a float16 backed canvas. Is the idea to propose adding a |
No. The function getImageData takes an The following code will always return sRGB float32 data, regardless of the color space or pixel format of the canvas itself. |
|
I see, thanks! |
|
I think this PR is in line with https://github.com/w3c/ColorWeb-CG/blob/main/hdr_html_canvas_element.md#extend-imagedatasettings-to-support-higher-bit-depths where the default value for @ccameron-chromium Can you confirm? |
Allow users to create 2d context with pixelFormat float16, i.e., users
can now create context like: ctx = canvas.getContext('2d',
{pixelFormat: 'float16'}).
Note that the default colortype for getImageData is uint8, so calls like
`ctx.getImageData(x, y, w, h)` without `colortype` returns pixels in
format uint8 with context of type float16.
proposal:
w3c/ColorWeb-CG#105
Bug: 1468666
Change-Id: I0309c6d8c573edc84a6a6643ea8ae9563986a242
Yes, that is correct, these result in the same behavior. (There is a slight difference in that one defines how things behave when this is not specified, which could be because no ImageDataOptions is specified, or because the ImageDataOptions does not specify dataType). |
No description provided.