Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single-get multi IDP support for passive mode #686

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

npm1
Copy link
Collaborator

@npm1 npm1 commented Dec 10, 2024

Adds support for multiple IDPs on passive mode by:

  • Not rejecting if the list passed is not of size 1.
  • Still rejecting if the list passed is not of size 1 and mode is active (it is possible this PR is later updated to remove this restriction)
  • Performing some per-IDP checks first, and computing a map based on the results
  • Showing UI for the relevant IDPs based on the results from the computations: optional UIs for logged out IDPs, mandatory UI for mismatch IDPs, and all accounts for IDPs that returned some accounts.
  • Add a configURL to IdentityCredential so the RP knows which IDP the credential corresponds to.

Also some unrelated errors noticed while drafting this PR are fixed.

Relevant issue: w3c-fedid/multi-idp#2


Preview | Diff

@npm1 npm1 requested a review from cbiesinger December 10, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant