Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ID assertion endpoint mode to CORS #547

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Change ID assertion endpoint mode to CORS #547

merged 2 commits into from
Aug 16, 2024

Conversation

npm1
Copy link
Collaborator

@npm1 npm1 commented Feb 27, 2024

Fixes #428


Preview | Diff

@npm1 npm1 requested a review from samuelgoto February 27, 2024 21:37
spec/index.bs Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Copy link
Collaborator

@samuelgoto samuelgoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npm1 npm1 added the agenda+ Regular CG meeting agenda items label Jul 25, 2024
@npm1
Copy link
Collaborator Author

npm1 commented Jul 30, 2024

Thanks for the review, will merge after the repo moves to the WG, per instructions on the call.

Copy link

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@samuelgoto samuelgoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@npm1 npm1 removed the agenda+ Regular CG meeting agenda items label Aug 2, 2024
@npm1 npm1 merged commit 90128b5 into main Aug 16, 2024
2 checks passed
@npm1 npm1 deleted the cors branch August 16, 2024 18:02
github-actions bot added a commit that referenced this pull request Aug 16, 2024
SHA: 90128b5
Reason: push, by npm1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
npm1 added a commit that referenced this pull request Sep 18, 2024
* Change ID assertion endpoint mode to CORS

* Update spec/index.bs

Co-authored-by: Ted Thibodeau Jr <[email protected]>

---------

Co-authored-by: Ted Thibodeau Jr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce CORS on the Identity Assertions endpoint
5 participants