Fix on macOS 10.13 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofcelba
commented
Mar 15, 2018
•
krystofcelba
commented
- SpotlightSIMBL.bundle now builds with Flashlight.app and Flashlight.app reinjects it everytime in debug mode. - Simply run Flashlight target in Xcode and test your changes.
The project can't be build because of hardcoded signing identities so I have set it to Don't code sign by default.
- Flashlight.app is now 1.0.7 - SpotlightSIMBL.bundle is 1.1.1
|
Do you know if your changes break anything on earlier MacOSes, Sierra, El Cap? |
The code becomes very messy due to commented absolete code
|
@tsimmons As of the recent commits, it reloads the results differently only on ^10.13 so there shouldn’t be issues. (I have tested it on 10.12 and works great) |
|
Just cloned and built on 10.13.3. Works beautifully! Nice work @krystofcelba! Seriously. |
w0lfschild
approved these changes
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.