Address further FIXMEs, from sylabs 2409 #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was disabled as it wasn't possible to run it within a PID namespace. Our e2e tests have not used a PID namespace for some time now, so we can enable it again. Signed-off-by: Vaiva Zokaite <[email protected]>
There isn't an easy way to replace `cp -fLr` with go code and be 100% certain that it has the exact same behaviour across all possible source / dest we could encounter when building a SCIF container. Drop the FIXME. We'll keep using `cp -fLr`. Signed-off-by: Vaiva Zokaite <[email protected]>
Not clear exactly why this was disabled / what 'too much variability in test results with CI' means. Possible due to an issue on older distros? It is passing for me. Signed-off-by: Vaiva Zokaite <[email protected]>
DrDaveD
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in sylabs PR
The original PR description was: