Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: move aside existing remote.yaml files in remoteUseExclusive() #393

Closed
wants to merge 1 commit into from
Closed

e2e: move aside existing remote.yaml files in remoteUseExclusive() #393

wants to merge 1 commit into from

Conversation

vzokay
Copy link
Owner

@vzokay vzokay commented Oct 2, 2024

This pulls in sylabs PR

  • sylabs/singularity# 2230

The original PR description was:

The e2e test "TestE2E/SEQ/REMOTE/use_exclusive" (remoteUseExclusive(), e2e/remote/remote.go:563) depends on there not being a remote.yaml in the root user's homedir prior to the test being run.

This PR adds code that moves existing remote.yaml in users' homedir aside for the duration of this test, and moves them back into place as part of the test's cleanup.

@vzokay
e2e: move aside existing remote.yaml files in remoteUseExclusive()
68bba65 
* move aside existing remote.yaml files in remoteUseExclusive()

* simplify {moveAside,restore}RemoteYAML

Signed-off-by: Vaiva Zokaite <[email protected]>
@vzokay vzokay requested a review from DrDaveD October 2, 2024 17:47
@vzokay vzokay marked this pull request as ready for review October 2, 2024 17:47
@vzokay vzokay closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrDaveD DrDaveD DrDaveD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vzokay @DrDaveD