Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for encrypted command data #588

Merged

Conversation

therecluse26
Copy link
Contributor

If a Laravel Job implements ShouldBeEncrypted, when dispatching it to RabbitMQ via this package throws the following error:

NOTICE unserialize(): Error at offset 0 of 17380 bytes in vendor/vladimir-yuldashev/laravel-queue-rabbitmq/src/Queue/RabbitMQQueue.php on line 528.

Added a bugfix to handle fetching priority from encrypted command data if the job class implements ShouldBeEncrypted

Added a bugfix to handle fetching priority from encrypted command data if the job class implements `ShouldBeEncrypted`
Copy link
Collaborator

@khepin khepin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests to this PR? Thank you!

src/Queue/RabbitMQQueue.php Show resolved Hide resolved
src/Queue/RabbitMQQueue.php Outdated Show resolved Hide resolved
@therecluse26
Copy link
Contributor Author

therecluse26 commented Apr 24, 2024

@khepin fixed requested changes and added tests

@therecluse26 therecluse26 requested a review from khepin April 25, 2024 01:17
@khepin khepin merged commit 3d58891 into vyuldashev:master Apr 26, 2024
10 checks passed
@therecluse26
Copy link
Contributor Author

@khepin just curious, does this package have a regular release cadence? When should I expect this to be available in a release?

@khepin
Copy link
Collaborator

khepin commented May 17, 2024

14.1.0 available now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants