refactor[ux]: add venom as experimental-codegen alias
#4337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -254,6 +254,8 @@ def get_settings(input_dict: dict) -> Settings: | |||
|
|
|||
| optimize = input_dict["settings"].get("optimize") | |||
| experimental_codegen = input_dict["settings"].get("experimentalCodegen") | |||
| if experimental_codegen is None: | |||
| experimental_codegen = input_dict["settings"].get("venom") | |||
There was a problem hiding this comment.
Maybe throw an exception if both are set
charles-cooper
changed the title
tests/unit/ast/test_pre_parser.py
Outdated
| @@ -218,6 +237,15 @@ def test_parse_pragmas(code, pre_parse_settings, compiler_data_settings, mock_ve | |||
| # pragma evm-version cancun | |||
| # pragma evm-version shanghai | |||
| """, | |||
| # duplicit setting of venom | |||
charles-cooper
changed the title
venom as experimental-codegen alias
charles-cooper
approved these changes
Nov 5, 2024
sandbubbles
added a commit
to sandbubbles/vyper
that referenced
this pull request
Nov 7, 2024
…4337) Make "venom" an alternative alias to the "experimental_codegen" flag. Add the alias to cli, pre-parser, and json parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Make a "venom" alias to "experimental_codegen" flag.
See #4334.
How I did it
Add the alias to cli, pre-parser, and json parser.
How to verify it
All exisiting tests work with old flas as well as new tests with
venom.Commit message
Description for the changelog
Cute Animal Picture