Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[venom]: clear out_vars during calculation #4129

Merged
merged 8 commits into from
Jun 12, 2024

Conversation

harkal
Copy link
Collaborator

@harkal harkal commented Jun 12, 2024

What I did

Fixed a bug where I was not clearing the out_vars of a basic block

How I did it

How to verify it

Commit message

Clear `out_vars` set at start of calculations

When computing `out_vars` for each basic block, we perform set unions
of variables expected by all successor basic blocks of the current block.
This commit clears the `out_vars` set at the beginning of the calculations.

Description for the changelog

Cute Animal Picture

 /\_/\  
( o.o ) 
 > ^ <

@harkal harkal marked this pull request as ready for review June 12, 2024 08:16
@charles-cooper
Copy link
Member

hmm, finding this causes some bytecode size regression in branch_storm.vy

@charles-cooper charles-cooper enabled auto-merge (squash) June 12, 2024 20:38
@charles-cooper charles-cooper merged commit 153262b into vyperlang:master Jun 12, 2024
155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants