Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[venom]: move loop invariant assertion to entry block #4098

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jun 8, 2024

What I did

How I did it

How to verify it

Commit message

loop invariant bound check was in the body of the loop, not the entry
block. move it up to the entry so we don't re-check the same assertion
every loop iteration.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

loop invariant bound check was in the body of the loop, not the entry
block. move it up, it improves code
@charles-cooper charles-cooper marked this pull request as ready for review June 8, 2024 02:49
@charles-cooper charles-cooper merged commit 4d1bacd into vyperlang:master Jun 10, 2024
156 checks passed
@charles-cooper charles-cooper deleted the fix/venom-bound-check branch June 10, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants