Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[docs]: implements does not check event declarations #4052

Merged
merged 4 commits into from
May 25, 2024
Merged

chore[docs]: implements does not check event declarations #4052

merged 4 commits into from
May 25, 2024

Conversation

pcaversaccio
Copy link
Collaborator

@pcaversaccio pcaversaccio commented May 25, 2024

What I did

Add a note in the docs that implements does not check emitted events.

How I did it

Brain.

How to verify it

Use hard skills.

Commit message

as of v0.4.0, `implements` does not check that events are (re-)defined
in the implementing contract

Description for the changelog

Add a note in the docs that implements does not check emitted events.

Cute Animal Picture

image

@pcaversaccio pcaversaccio self-assigned this May 25, 2024
@pcaversaccio pcaversaccio added the documentation Documentation label May 25, 2024
@pcaversaccio pcaversaccio changed the title docs[chore]: implements does not check emitted events chore[docs]: implements does not check emitted events May 25, 2024
@charles-cooper charles-cooper changed the title chore[docs]: implements does not check emitted events chore[docs]: implements does not check event declarations May 25, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) May 25, 2024 11:56
@charles-cooper charles-cooper merged commit abf795a into vyperlang:master May 25, 2024
155 checks passed
@pcaversaccio pcaversaccio deleted the docs/implements-events branch May 25, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants