feat[tool]!: make cancun the default evm version #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update tests and change defaults so that cancun is the default evm version
charles-cooper
requested review from
fubuloubu,
harkal,
cyberthirst and
pcaversaccio
harkal
approved these changes
May 16, 2024
fubuloubu
approved these changes
May 16, 2024
pcaversaccio
approved these changes
May 16, 2024
docs/compiling-a-contract.rst
Outdated
| @@ -237,7 +237,7 @@ The following example describes the expected input format of ``vyper-json``. Com | |||
| }, | |||
| // Optional | |||
| "settings": { | |||
| "evmVersion": "shanghai", // EVM version to compile for. Can be london, paris, shanghai (default) or cancun (experimental!). | |||
| "evmVersion": "shanghai", // EVM version to compile for. Can be london, paris, shanghai or cancun (default). | |||
There was a problem hiding this comment.
This file should have all default values.
Suggested change
| "evmVersion": "shanghai", // EVM version to compile for. Can be london, paris, shanghai or cancun (default). | |
| "evmVersion": "cancun", // EVM version to compile for. Can be london, paris, shanghai or cancun (default). |
charles-cooper
changed the title
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
May 17, 2024
### 🕓 Changelog All 🐍 snekmate contracts now target the new Vyper default EVM version `cancun` (see vyperlang/vyper#4029). I also bump the Vyper version to the latest release candidate [`v0.4.0rc5`](https://github.com/vyperlang/vyper/releases/tag/v0.4.0rc5). --------- Signed-off-by: Pascal Marco Caversaccio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update tests and change defaults so that cancun is the default evm version
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture