Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[ux]: remove deprecated VyperNode properties #3999

Merged
merged 7 commits into from
May 7, 2024

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented May 4, 2024

What I did

Depends on #3998.

Remove deprecated properties from Num and Str vyper nodes following in the spirit of the equivalent deprecated python AST classes.

How I did it

How to verify it

Commit message

This commit removes the `n` property from `Num` vyper node and the `s`
property from `Str` vyper node as they have been deprecated in the
python AST (and it is clearer to use the `value` property anyways)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper marked this pull request as ready for review May 7, 2024 12:32
@charles-cooper
Copy link
Member

@tserg this is ready for review right?

@tserg
Copy link
Collaborator Author

tserg commented May 7, 2024

@tserg this is ready for review right?

Yes, just pulled the latest master.

@charles-cooper charles-cooper changed the title refactor[ux]: remove properties for Num and Str vyper nodes refactor[ux]: remove deprecated properties on vyper nodes May 7, 2024
@charles-cooper charles-cooper changed the title refactor[ux]: remove deprecated properties on vyper nodes refactor[ux]: remove deprecated properties on Num and Str AST nodes May 7, 2024
@charles-cooper charles-cooper changed the title refactor[ux]: remove deprecated properties on Num and Str AST nodes refactor[ux]: remove deprecated AST node properties May 7, 2024
@charles-cooper charles-cooper changed the title refactor[ux]: remove deprecated AST node properties refactor[ux]: remove deprecated AST node properties May 7, 2024
@charles-cooper charles-cooper changed the title refactor[ux]: remove deprecated AST node properties refactor[ux]: remove deprecated VyperNode properties May 7, 2024
@charles-cooper charles-cooper merged commit 6d4c09c into vyperlang:master May 7, 2024
156 checks passed
@tserg tserg deleted the chore/vy_nodes branch May 7, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants