Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[codegen]: fix double evals in sqrt, slice, blueprint #3976

Merged
merged 16 commits into from
May 16, 2024

Conversation

cyberthirst
Copy link
Collaborator

What I did

fix for:

How I did it

cache respective args

How to verify it

added new tests for side-effect evaluations for the respective builtins

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 3.33333% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 51.01%. Comparing base (626cdf9) to head (df7c7c6).
Report is 1 commits behind head on master.

❗ Current head df7c7c6 differs from pull request most recent head 7e4e4b7. Consider uploading reports for the commit 7e4e4b7 to get more accurate results

Files Patch % Lines
vyper/builtins/functions.py 3.33% 29 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3976       +/-   ##
===========================================
- Coverage   90.97%   51.01%   -39.96%     
===========================================
  Files         106      105        -1     
  Lines       15288    15267       -21     
  Branches     3367     3365        -2     
===========================================
- Hits        13908     7789     -6119     
- Misses        942     6852     +5910     
- Partials      438      626      +188     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper added this to the v0.4.0 milestone May 7, 2024
@cyberthirst cyberthirst marked this pull request as ready for review May 12, 2024 14:41
@charles-cooper charles-cooper merged commit 0453f63 into vyperlang:master May 16, 2024
153 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants