fix[lang]: builtin type comparisons #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior to this commit, due to re-loading and re-analysing the builtin modules, the types defined in those modules do not compare when they are imported in different files. this commit globally(!) caches the builtin modules. the global scope should be safe, since builtins are always stable across compilations.
harkal
approved these changes
Apr 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3956 +/- ##
==========================================
- Coverage 90.87% 89.02% -1.85%
==========================================
Files 95 95
Lines 14449 14454 +5
Branches 3204 3205 +1
==========================================
- Hits 13130 12868 -262
- Misses 911 1123 +212
- Partials 408 463 +55 ☔ View full report in Codecov by Sentry. |
pcaversaccio
approved these changes
Apr 15, 2024
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
prior to this commit, due to re-loading and re-analysing the builtin modules, the types defined in those modules do not compare when they are imported in different files. this commit globally(!) caches the builtin modules, ensuring builtin types compare correctly no matter how they are imported. the global scope should be safe, since builtins are always stable across compilations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fix #3954
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture