-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[lang]!: add feature flag for decimals #3930
Merged
charles-cooper
merged 9 commits into
vyperlang:master
from
charles-cooper:feat/decimal-feature-flag
Apr 10, 2024
Merged
feat[lang]!: add feature flag for decimals #3930
charles-cooper
merged 9 commits into
vyperlang:master
from
charles-cooper:feat/decimal-feature-flag
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
changed the title
[wip] feat: add feature flag for decimals
feat[lang]!: add feature flag for decimals
Apr 9, 2024
charles-cooper
force-pushed
the
feat/decimal-feature-flag
branch
from
April 10, 2024 14:52
e6b3ac3
to
ccc1e16
Compare
harkal
approved these changes
Apr 10, 2024
charles-cooper
force-pushed
the
feat/decimal-feature-flag
branch
from
April 10, 2024 15:22
ccc1e16
to
f418cb3
Compare
charles-cooper
force-pushed
the
feat/decimal-feature-flag
branch
from
April 10, 2024 15:59
e78cffc
to
5e4e650
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3930 +/- ##
==========================================
- Coverage 90.89% 90.83% -0.06%
==========================================
Files 95 95
Lines 14393 14414 +21
Branches 3190 3196 +6
==========================================
+ Hits 13082 13093 +11
- Misses 908 915 +7
- Partials 403 406 +3 ☔ View full report in Codecov by Sentry. |
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
hide decimals behind a feature flag. this informally lets us "break the compatibility contract" with users by moving decimals into quasi-experimental status; this way we can iterate on the decimals design faster in the 0.4.x series instead of needing to wait for breaking releases to make changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
depends #3929
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture