Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[lang]!: add feature flag for decimals #3930

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Apr 9, 2024

What I did

depends #3929

How I did it

How to verify it

Commit message

hide decimals behind a feature flag. this informally lets us "break the
compatibility contract" with users by moving decimals into
quasi-experimental status; this way we can iterate on the decimals
design faster in the 0.4.x series instead of needing to wait for
breaking releases to make changes.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper changed the title [wip] feat: add feature flag for decimals feat[lang]!: add feature flag for decimals Apr 9, 2024
vyper/semantics/types/utils.py Dismissed Show dismissed Hide dismissed
tests/conftest.py Dismissed Show dismissed Hide dismissed
vyper/compiler/phases.py Fixed Show fixed Hide fixed
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 90.83%. Comparing base (e4f1c24) to head (ba8868a).

Files Patch % Lines
vyper/ast/pre_parser.py 0.00% 3 Missing and 1 partial ⚠️
vyper/cli/vyper_compile.py 33.33% 1 Missing and 1 partial ⚠️
vyper/compiler/settings.py 66.66% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3930      +/-   ##
==========================================
- Coverage   90.89%   90.83%   -0.06%     
==========================================
  Files          95       95              
  Lines       14393    14414      +21     
  Branches     3190     3196       +6     
==========================================
+ Hits        13082    13093      +11     
- Misses        908      915       +7     
- Partials      403      406       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper marked this pull request as ready for review April 10, 2024 16:31
@charles-cooper charles-cooper enabled auto-merge (squash) April 10, 2024 17:01
@charles-cooper charles-cooper merged commit 44a593a into vyperlang:master Apr 10, 2024
149 checks passed
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
hide decimals behind a feature flag. this informally lets us "break the
compatibility contract" with users by moving decimals into
quasi-experimental status; this way we can iterate on the decimals
design faster in the 0.4.x series instead of needing to wait for
breaking releases to make changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants