Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[docs]: amend revert_on_failure kwarg docs for create builtins #3921

Merged
merged 3 commits into from
Apr 10, 2024
Merged

chore[docs]: amend revert_on_failure kwarg docs for create builtins #3921

merged 3 commits into from
Apr 10, 2024

Conversation

pcaversaccio
Copy link
Collaborator

What I did

As title.

How I did it

Obvious.

How to verify it

N/A.

Commit message

chore[docs]: amend `revert_on_failure` kwarg docs for create builtins

Description for the changelog

chore[docs]: amend `revert_on_failure` kwarg docs for create builtins

Cute Animal Picture

image

@pcaversaccio
Copy link
Collaborator Author

Hmm, I don't think this rule is so smart...
image

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.57%. Comparing base (8697519) to head (6d9c8c7).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3921      +/-   ##
==========================================
- Coverage   90.84%   90.57%   -0.28%     
==========================================
  Files          95       95              
  Lines       14414    14414              
  Branches     3196     3196              
==========================================
- Hits        13095    13056      -39     
- Misses        913      947      +34     
- Partials      406      411       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title chore[docs]: amend revert_on_failure kwarg docs for create builtins chore[docs]: update revert_on_failure kwarg docs for create builtins Apr 10, 2024
@charles-cooper
Copy link
Member

Hmm, I don't think this rule is so smart... image

#3937

@charles-cooper charles-cooper changed the title chore[docs]: update revert_on_failure kwarg docs for create builtins chore[docs]: amend revert_on_failure kwarg docs for create builtins Apr 10, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) April 10, 2024 17:33
@charles-cooper charles-cooper merged commit 5734ce2 into vyperlang:master Apr 10, 2024
149 checks passed
@pcaversaccio pcaversaccio deleted the docs/revert_on_failure branch April 10, 2024 18:03
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants