Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[ci]: add PR title validation #3887

Merged
merged 22 commits into from
Mar 23, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 23, 2024

What I did

ensure PR titles conform to conventional commits. scopes are now required!

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (fd49ead) to head (665fecb).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3887      +/-   ##
==========================================
- Coverage   86.39%   86.36%   -0.03%     
==========================================
  Files          92       92              
  Lines       14024    14024              
  Branches     3081     3081              
==========================================
- Hits        12116    12112       -4     
- Misses       1480     1484       +4     
  Partials      428      428              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title feat[ci]: validate PR titles feat(ci): validate PR titles Mar 23, 2024
@charles-cooper charles-cooper marked this pull request as draft March 23, 2024 12:39
@charles-cooper charles-cooper marked this pull request as ready for review March 23, 2024 12:44
@charles-cooper charles-cooper changed the title feat(ci): validate PR titles feat[ci]: validate PR titles Mar 23, 2024
@charles-cooper charles-cooper changed the title feat[ci]: validate PR titles feat[ci]: Validate PR titles Mar 23, 2024
@charles-cooper charles-cooper changed the title feat[ci]: Validate PR titles feat[ci]: validate PR titles Mar 23, 2024
@charles-cooper charles-cooper changed the title feat[ci]: validate PR titles feat[asdlfkj]: validate PR titles Mar 23, 2024
@charles-cooper charles-cooper changed the title feat[asdlfkj]: validate PR titles feat[ci]: validate PR titles Mar 23, 2024
@charles-cooper charles-cooper force-pushed the ci/conventional-commit branch 2 times, most recently from 1ad61ed to 3adc4e3 Compare March 23, 2024 13:23
@charles-cooper charles-cooper changed the title feat[ci]: validate PR titles feat[ci]: add conventional-commit validation to PR titles Mar 23, 2024
@charles-cooper charles-cooper changed the title feat[ci]: add conventional-commit validation to PR titles feat[ci]: add conventional-commit validation to pull requests Mar 23, 2024
@charles-cooper charles-cooper changed the title feat[ci]: add conventional-commit validation to pull requests feat[ci]: add validation to pull request metadata Mar 23, 2024
@charles-cooper charles-cooper changed the title feat[ci]: add validation to pull request metadata feat[ci]: add PR title validation Mar 23, 2024
@charles-cooper charles-cooper merged commit b557e19 into vyperlang:master Mar 23, 2024
149 checks passed
@charles-cooper charles-cooper deleted the ci/conventional-commit branch March 23, 2024 14:14
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
add conventional commit style validation to pull request titles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants