-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[ci]: add PR title validation #3887
Merged
charles-cooper
merged 22 commits into
vyperlang:master
from
charles-cooper:ci/conventional-commit
Mar 23, 2024
Merged
feat[ci]: add PR title validation #3887
charles-cooper
merged 22 commits into
vyperlang:master
from
charles-cooper:ci/conventional-commit
Mar 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
force-pushed
the
ci/conventional-commit
branch
from
March 23, 2024 11:55
719a0da
to
f33482e
Compare
charles-cooper
force-pushed
the
ci/conventional-commit
branch
from
March 23, 2024 12:07
4217453
to
b97562b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3887 +/- ##
==========================================
- Coverage 86.39% 86.36% -0.03%
==========================================
Files 92 92
Lines 14024 14024
Branches 3081 3081
==========================================
- Hits 12116 12112 -4
- Misses 1480 1484 +4
Partials 428 428 ☔ View full report in Codecov by Sentry. |
charles-cooper
changed the title
feat[ci]: validate PR titles
feat(ci): validate PR titles
Mar 23, 2024
charles-cooper
changed the title
feat(ci): validate PR titles
feat[ci]: validate PR titles
Mar 23, 2024
charles-cooper
changed the title
feat[ci]: validate PR titles
feat[ci]: Validate PR titles
Mar 23, 2024
charles-cooper
changed the title
feat[ci]: Validate PR titles
feat[ci]: validate PR titles
Mar 23, 2024
charles-cooper
changed the title
feat[ci]: validate PR titles
feat[asdlfkj]: validate PR titles
Mar 23, 2024
charles-cooper
changed the title
feat[asdlfkj]: validate PR titles
feat[ci]: validate PR titles
Mar 23, 2024
charles-cooper
force-pushed
the
ci/conventional-commit
branch
2 times, most recently
from
March 23, 2024 13:23
1ad61ed
to
3adc4e3
Compare
charles-cooper
changed the title
feat[ci]: validate PR titles
feat[ci]: add conventional-commit validation to PR titles
Mar 23, 2024
charles-cooper
changed the title
feat[ci]: add conventional-commit validation to PR titles
feat[ci]: add conventional-commit validation to pull requests
Mar 23, 2024
charles-cooper
force-pushed
the
ci/conventional-commit
branch
from
March 23, 2024 13:27
3adc4e3
to
ea65dc0
Compare
charles-cooper
changed the title
feat[ci]: add conventional-commit validation to pull requests
feat[ci]: add validation to pull request metadata
Mar 23, 2024
charles-cooper
changed the title
feat[ci]: add validation to pull request metadata
feat[ci]: add PR title validation
Mar 23, 2024
cyberthirst
approved these changes
Mar 23, 2024
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
add conventional commit style validation to pull request titles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ensure PR titles conform to conventional commits. scopes are now required!
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture