feat[lang]!: change the signature of block.prevrandao
#3879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`block.prevrandao` is an opcode alias for `difficulty`. however, it returns a bytes object at the evm level (cf. for instance py-evm returns the value of `block.mixhash`). this commit changes the signature of block.prevrandao to be more consistent with the VM semantics.
charles-cooper
requested review from
fubuloubu,
harkal,
cyberthirst and
pcaversaccio
pcaversaccio
approved these changes
Mar 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3879 +/- ##
==========================================
- Coverage 86.36% 86.33% -0.04%
==========================================
Files 92 92
Lines 14024 14024
Branches 3081 3081
==========================================
- Hits 12112 12107 -5
- Misses 1484 1489 +5
Partials 428 428 ☔ View full report in Codecov by Sentry. |
fubuloubu
approved these changes
Mar 23, 2024
fubuloubu
changed the title
block.prevrandaoblock.prevrandao
cyberthirst
approved these changes
Mar 23, 2024
add optional ! which indicates a breaking change
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
`block.prevrandao` is an opcode alias for `difficulty`. however, it returns a bytes object at the evm level (cf. for instance py-evm returns the value of `block.mixhash`). this commit changes the signature of `block.prevrandao` to be more consistent with the VM semantics. also update PR title regex per conventional commit specification - add optional `!` which indicates a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block.prevrandaois an opcode alias fordifficulty. however, it returns a bytes object at the evm level (cf. for instance py-evm returns the value ofblock.mixhash). this commit changes the signature of block.prevrandao to be more consistent with the VM semantics.What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture