fix[codegen]: fix non-memory reason strings #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3877 +/- ##
==========================================
- Coverage 86.36% 86.27% -0.09%
==========================================
Files 92 92
Lines 14024 14022 -2
Branches 3081 3080 -1
==========================================
- Hits 12112 12098 -14
- Misses 1484 1494 +10
- Partials 428 430 +2 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,28 +1,23 @@ | |||
| import vyper.codegen.events as events | |||
| import vyper.utils as util | |||
| from vyper import ast as vy_ast | |||
| from vyper.codegen.abi_encoder import abi_encode | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
charles-cooper
changed the title
charles-cooper
changed the title
charles-cooper
approved these changes
Mar 24, 2024
charles-cooper
changed the title
electriclilies
pushed a commit
to electriclilies/vyper
that referenced
this pull request
Apr 27, 2024
fix code generation for non-memory reason strings. previously, the byte array copier would fail trying to produce code for the buf, which was an int rather than an IRnode. this commit cleans up the revert generation code, allocates a fresh buffer to avoid memory cleanliness issues, and refactors the code to use abi_encoder code instead of handrolling the ABI encoding routine. --------- Co-authored-by: Charles Cooper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #3787, fix #3251
How I did it
Made recommended fix.
How to verify it
See tests
Commit message
Description for the changelog
Cute Animal Picture