-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[lang]: add revert_on_failure
kwarg for create builtins
#3844
feat[lang]: add revert_on_failure
kwarg for create builtins
#3844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be nice to have specific tests for the revert_on_failure behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update the docs for these built-ins as part of that PR IMO.
Convention-wise, we should return the address 0x0
if revert_on_failure=False
and the creation fails, agreed @charles-cooper?
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3844 +/- ##
==========================================
- Coverage 90.02% 89.20% -0.82%
==========================================
Files 95 95
Lines 14411 14411
Branches 3193 3193
==========================================
- Hits 12973 12855 -118
- Misses 1012 1110 +98
- Partials 426 446 +20 ☔ View full report in Codecov by Sentry. |
revert_on_failure
kwarg for create builtins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please update the docs before merging.
…ang#3844) per title. add `revert_on_failure=` kwarg for create builtins to mirror `raw_call()`. among other things, this makes it easier to calculate create addresses. --------- Co-authored-by: Charles Cooper <[email protected]>
Fixes #3744
What I did
revert_on_failure: bool = True
to contract creation built-in functionsHow I did it
How to verify it
Commit message
Description for the changelog
Support kwarg
revert_on_failure: bool = True
for contract creation built-in functionsCute Animal Picture