Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add another borrowship test #3802

Merged

Conversation

charles-cooper
Copy link
Member

clarify the behavior of storage access through nested attribute access

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

clarify the behavior of storage access through nested attribute access
Copy link
Contributor

@trocher trocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@cyberthirst cyberthirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc57775) 85.02% compared to head (e869f46) 84.99%.
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3802      +/-   ##
==========================================
- Coverage   85.02%   84.99%   -0.04%     
==========================================
  Files          92       92              
  Lines       13733    13771      +38     
  Branches     3078     3084       +6     
==========================================
+ Hits        11677    11705      +28     
- Misses       1568     1576       +8     
- Partials      488      490       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper enabled auto-merge (squash) February 22, 2024 15:09
@charles-cooper charles-cooper enabled auto-merge (squash) February 22, 2024 15:10
@charles-cooper charles-cooper merged commit f8edd29 into vyperlang:master Feb 22, 2024
84 checks passed
@charles-cooper charles-cooper deleted the chore/add-borrowship-test branch February 22, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants