feat: improve warnings, refactor vyper_warn()
#3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -9,7 +9,7 @@ | |||
| import warnings | |||
| from typing import Generic, List, TypeVar, Union | |||
|
|
|||
| from vyper.exceptions import CompilerPanic, DecimalOverrideException, InvalidLiteral | |||
| from vyper.exceptions import CompilerPanic, DecimalOverrideException, InvalidLiteral, VyperException | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
fubuloubu
approved these changes
Feb 22, 2024
charles-cooper
changed the title
vyper_warn()vyper_warn()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
add source information to
vyper_warn()to give more helpful warningsHow I did it
How to verify it
write some vyper code with old-style structs, like
see that the warning includes the source location after this commit.
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture