-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: levenshtein optimization #3780
perf: levenshtein optimization #3780
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3780 +/- ##
==========================================
- Coverage 84.99% 84.98% -0.01%
==========================================
Files 92 92
Lines 13702 13709 +7
Branches 3074 3077 +3
==========================================
+ Hits 11646 11651 +5
- Misses 1569 1570 +1
- Partials 487 488 +1 ☔ View full report in Codecov by Sentry. |
7b39164
to
e110e35
Compare
defer the call to `levenshtein` until we need an error message
e110e35
to
4170241
Compare
by the way, as of this PR, compilation time has come down 45% since v0.3.10! # this PR
$ time vyc tmp/CurveStableSwapNG-0.4.0.vy >/dev/null
real 0m3.960s
user 0m3.810s
sys 0m0.148s
# v0.3.10
$ time vyc tmp/CurveStableSwapNG.vy >/dev/null
real 0m7.683s
user 0m7.474s
sys 0m0.206s
$ python
Python 3.11.7 (main, Dec 8 2023, 18:56:58) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> 4.6/7.7
0.5974025974025974 |
What I did
How I did it
How to verify it
find some large contract (e.g. CurveStableSwapNG.vy), try
vyc -f annotated_ast
andvyc -f bytecode
.Commit message
Description for the changelog
Cute Animal Picture