fix: opcodes
and opcodes_runtime
outputs
#3735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed the
opcodes
andopcodes_runtime
outputs as they would not respectively match thebytecode
andbytecode_runtime
outputs.The value following a
PUSH
instruction could be incorrect. For example, when compiling some Vyper code that results inPUSH2 0x100
:bytecode
output would be610100
opcodes
output would bePUSH2 0x10
instead ofPUSH2 0x100
This issue is due to a lack of 0 padding.
How I did it
In
build_opcodes
, left pad each byte to be concatenated with 0 to have a length of 2 digitsHow to verify it
Check the tests
Commit message
Description for the changelog
Cute Animal Picture