-
-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add bb
and bb_runtime
output options
#3700
feat: Add bb
and bb_runtime
output options
#3700
Conversation
i think i would rather have a new output type (bring back |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3700 +/- ##
==========================================
- Coverage 84.22% 84.15% -0.08%
==========================================
Files 92 92
Lines 13073 13038 -35
Branches 2916 2919 +3
==========================================
- Hits 11011 10972 -39
- Misses 1644 1646 +2
- Partials 418 420 +2 ☔ View full report in Codecov by Sentry. |
01cec45
to
f16d35a
Compare
a515980
to
88b4830
Compare
bb
and bb_runtime
output options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think maybe for test cleanliness we can introduce a new fixture output_formats
@pytest.fixture
def output_formats():
return [k for k in compiler.OUTPUT_FORMATS.keys() if k not in ("bb", "bb_runtime")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
What I did
Currently running tests with experimental codegen was failing due to ir_dict output not being compatible.
This small patch rectifies all that and adds
bb
andbb_runtime
as output optionsHow I did it
How to verify it
Commit message
Add
bb
andbb_runtime
output optionsDescription for the changelog
Cute Animal Picture