Refactor ctx.add_instruction() and friends #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_instruction methods
adopted a shorted name for frequently used methods
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3685 +/- ##
==========================================
+ Coverage 83.82% 83.95% +0.12%
==========================================
Files 91 91
Lines 12778 12769 -9
Branches 2861 2867 +6
==========================================
+ Hits 10711 10720 +9
+ Misses 1643 1624 -19
- Partials 424 425 +1 ☔ View full report in Codecov by Sentry. |
Refactored append instructions into a single append_instruction() method with named arguments for returning or not a variable
harkal
changed the title
|
@harkal some failing tests! |
Until now log instructions where pass through. Now we have a log instruction in venom that takes the first argument to be the topic count (in shape of doing table jmp etc in the future -essentialy have instructions that require manipulation of operants before emit)
Remove output argument append_instruction() in IRBasicBlock now the method decides by itself if there is an output value
…_add_instruction_and_friends
Co-authored-by: Charles Cooper <[email protected]>
charles-cooper
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Refactored the family of add instruction methods in IRFunction and IRBasicBlock with the aim to only using basic block methods to add instructions
How I did it
With lots of coffee
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture